search

lgrignon / jsweet-gradle-plugin

Brings the power of JSweet to Gradle
Apache License 2.0
17 stars 15 forks source link

unit test, bump dependencies, added more transpiler options support #32

Closed regrog closed 3 years ago

regrog commented 3 years ago

Hi,

I needed to create a sample to test the errors with jdk 11. Well I ended up setting some unit test and I also discover some property setting missing for the transpiler that I think I should use. Didn't have time to test on my sample project yet, You can wait to merge until I complete the test.

I added test support in build.gradle. Tell me if you don't like the apply eclipse plugin or if something you don't like hehehe.

Thanks

lgrignon commented 3 years ago

Hello,

Thanks again for your contribution. I like those tests, it's enjoyable to see more and more tests :) Just to be sure you are aware of that: there are a bunch of unit tests in https://github.com/cincheo/jsweet/tree/develop/transpiler therefore I think it's good to have some additional tests in gradle plugin related to gradle transpilation, but it would be pointless to cover a lot of transpilation test cases :)

I am not sure about the Eclipse part: can you confirm it will be still possible to use the gradle plugin without Eclipse? (command line, IntelliJ, etc..) My understanding is "yes" :) If so, then this is perfect.

Please tell me when you feel like it's finished and I will merge :)

regrog commented 3 years ago

I agree with you, add too many tests here is useless. The few I added are enough I think to ensure the right match to the transpiler. These test helped me to understand if the error was the configuration I did in my sample plugin (talking about my jdk 11 stacktrace issue) or something else. Well the error was mine and now again I need to dive more.

The Eclipse part is something that should not impact other IDE or command line. It's only necessary to sync .project and .classpath

I think I'm done here. You can merge.