search

lgrignon / jsweet-maven-plugin

JSweet maven plugin providing build and clean operations of JSweet sources
Apache License 2.0
18 stars 20 forks source link

Enable Usage of Custom Factory Classes in Plugin #42

Closed pbtura closed 6 years ago

pbtura commented 6 years ago

These changes enable custom Jsweet factory classes to be used in a project without having to spilt those classes out into a separate jar. The plugin dependencies also had to be updated to support the new code.

fixes issue #40

lgrignon commented 6 years ago

Thank you very much, this is so great! Can I ask why did you exclude guava?

lgrignon commented 6 years ago

Do you have a GitHub showing a use case of this so we could publish in the maven plugin's README? Or directly in the JSweet documentation?

Thanks again!

pbtura commented 6 years ago

I originally excluded guava to work around a conflict with the guava version in maven-core. Since you mentioned it I took another look and found a more recent version of maven-core with a newer version of guava. That fixed the conflicts so I went ahead and removed those exclusions.

lgrignon commented 6 years ago

Very nice. I will merge today I think.

pbtura commented 6 years ago

Here is a link to the git I have been using to test this: https://github.com/pbtura/bigjsExample/tree/maven-plugin-demo

If you want to fork this project, make sure you fork off of the maven-plugin-demo branch. The master branch includes code related to work on another issue I was testing for.

lgrignon commented 6 years ago

Thanks. I will use it. I am currently merging. Note: I revert your version change. For now we stick to version 2.2.0-SNAPSHOT. I am about to release 2.2.0 for JSweet and the Maven plugin. Possibly the gradle plugin if I find time

pbtura commented 6 years ago

Ok. Thanks.

On Thu, May 10, 2018 at 11:40 AM, Louis Grignon notifications@github.com wrote:

Thanks. I will use it. I am currently merging. Note: I revert your version change. For now we stick to version 2.2.0-SNAPSHOT. I am about to release 2.2.0 for JSweet and the Maven plugin. Possibly the gradle plugin if I find time

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lgrignon/jsweet-maven-plugin/pull/42#issuecomment-388092602, or mute the thread https://github.com/notifications/unsubscribe-auth/AFO7BJT7LXQAvYNpAdYcCHAKLvo3aBlqks5txF9egaJpZM4T4_mM .

lgrignon commented 6 years ago

Merged and deployed (2.2.0-SNAPSHOT), please see 474c0b6