search

lgromanowski / acme-plugin

:lock_with_ink_pen: ACME protocol plugin for Ruby on Rails applications
https://rubygems.org/gems/acme_plugin
MIT License
186 stars 30 forks source link

Rails 5 #35

Closed halo closed 8 years ago

halo commented 8 years ago

Several people are forking this gem to do just one thing: Change the rails dependency from ~> 4 to >= 4 so as to allow for Rails 5.

I see that there is an (outdated) rails5 branch. Is there any reason for not changing at least the Rails version dependency in master?

mathieujobin commented 8 years ago

PR #37

Spone commented 8 years ago

@lgromanowski hi, the PR has been merged, so I think you can close this issue.

mathieujobin commented 8 years ago

@halo can also close it

thanks for the merge @lgromanowski

lgromanowski commented 8 years ago

Closing, thanks!

halo commented 8 years ago

By the way, it would be nice to see this published on rubygems.org as well. The latest version there (0.0.8 from March 2016) doesn't have this fix.

Thank you!

lgromanowski commented 8 years ago

Hi, I'm going to spend some time on letsencrypt_plugin next week, so I think I'll do a 0.0.9 release then.