Add support for private keys provided as strings

lgromanowski / acme-plugin

:lock_with_ink_pen: ACME protocol plugin for Ruby on Rails applications

https://rubygems.org/gems/acme_plugin

MIT License

186 stars 30 forks source link

Add support for private keys provided as strings #47

Closed jasper-lyons closed 8 years ago

jasper-lyons commented 8 years ago

Note: happy to update documentation for this once merged.

This request provided the ability for private keys to be provided as strings.

Use Case: When working with systems with ephemeral filesystems one would need to put the key file on the server, potentially committing it to git which is a fairly large security hole.

This means that you can safely use this plugin on Heroku.

lgromanowski commented 8 years ago

Unfortunately I can't merge it at this moment - 3 test are failing:

test_if_challenge_is_valid
test_if_challenge_request_is_invalid_if_it_is_larger_than_256_bytes
test_if_challenge_request_is_invalid_when_is_smaller_than_128_bits

jasper-lyons commented 8 years ago

Figured out what my issue was.

The fixtures persisted in the db after my initial test runs and so when removing code form the test_helper and running test to see if things worked there was a hidden bug, the fixtures were not loaded.

Might be worth using a db cleaner? Either way, latest push should fix the things I broke!

lgromanowski commented 8 years ago

Merged, thanks! :)