WEBUI : Misleading incompatibility notice when no cluster is selected in a simulation

lgsvl / simulator

A ROS/ROS2 Multi-robot Simulator for Autonomous Vehicles

Other

2.29k stars 780 forks source link

WEBUI : Misleading incompatibility notice when no cluster is selected in a simulation #1563

Open MaxandreOgeret opened 3 years ago

MaxandreOgeret commented 3 years ago

Hello,

When a simulation is not linked to any cluster (for example when the cluster is deleted) the simulation overview alerts will display misleading messages :

Those message shouldn't appear as they refer to the 'simulation cluster version' which doesn't exist. And how is it possible that it checks a cluster version if there is no cluster ?

For me the right solution would be to have a dedicated alert when no cluster is displayed that will prevent other alerts to be displayed.

Thanks !

lemketron commented 3 years ago

For me the right solution would be to have a dedicated alert when no cluster is displayed that will prevent other alerts to be displayed.

You are correct! Fix the cluster first and the other messages will likely go away (and should not be presented as long as the cluster is invalid).

I encountered this same issue myself just this morning. We will investigate that.