search

lgsvl / simulator

A ROS/ROS2 Multi-robot Simulator for Autonomous Vehicles
Other
2.27k stars 780 forks source link

Bridge Autopilot Type Doesn't Show Up #1713

Open alperenbayraktar opened 3 years ago

alperenbayraktar commented 3 years ago

image I have uploaded a custom ROS bridge but it doesn't show the Autoware options on the Simulation options tab. image

EricBoiseLGSVL commented 3 years ago

Adding @mark-gerow-lge to confirm custom bridge has been set correctly. Thanks

mark-gerow-lge commented 3 years ago

Can you show me what your BridgeNameAttribute tag on your IBridgeFactory implementation?

alperenbayraktar commented 3 years ago

Can you show me what your BridgeNameAttribute tag on your IBridgeFactory implementation?

@mark-gerow-lge It's name and type are both "CustomRos"

image

Maestroxr commented 3 years ago

This also happens with the original ROS2 bridge that is on the site's store by default. The Autoware options are grayed out even if the built-in bridge is used and this just happened after hanging the bridge and changing it back, so things that worked until recently stopped working now because I can't revert the setting and be able to save the simulation setting.

mark-gerow-lge commented 3 years ago

@alperenbayraktar the second term should be ROS, those are the types WISE recognizes for connecting an autopilot.

[BridgeName("CustomRos", "ROS")]

alperenbayraktar commented 3 years ago

@alperenbayraktar the second term should be ROS, those are the types WISE recognizes for connecting an autopilot.

[BridgeName("CustomRos", "ROS")]

@mark-gerow-lge I also took another build with type "ROS" when I first got this error, and updated the bridge, and got the same result. -Tried again but it doesn't help, here's how the manifest looks like: image

alperenbayraktar commented 3 years ago

@EricBoiseLGSVL Updating the asset doesn't fix the issue, it is still green and autopilots doesn't show

EricBoiseLGSVL commented 3 years ago

@mark-gerow-lge can you look at this again please? @alperenbayraktar Have you purged all bridges and uploaded the new one with the [BridgeName("CustomRos", "ROS")] changes?

alperenbayraktar commented 3 years ago

@mark-gerow-lge can you look at this again please? @alperenbayraktar Have you purged all bridges and uploaded the new one with the [BridgeName("CustomRos", "ROS")] changes?

Yes, as I said, I've tried with both ROS and CustomRos types before too. It has ROS as type, double-checked it from the manifest. Removed the configs that use the bridge from my library and then the bridge itself, uploaded it again. The bridge doesn't show up on the "Public" tab now and I just signed up a second account and shared the bridge because it doesn't show up on the vehicle config when this happens. The second account's vehicle config is also green and autopilots don't appear.

EricBoiseLGSVL commented 2 years ago

Looking at a webui fix for this. This is odd that it is still happening.