search

lgtmco / lgtm

LGTM is a simple pull request approval system [ARCHIVE]
Apache License 2.0
988 stars 140 forks source link

datastore.go missing postgres driver #43

Closed marcinwyszynski closed 8 years ago

marcinwyszynski commented 8 years ago

The driver is not registered since it's not imported. Importing github.com/lib/pq should do the trick.

bradrydzewski commented 8 years ago

postgres is not a supported driver. Even if we imported the postgres driver the sql queries and database migrations would fail, since postgres is not compatible with sqlite or mysql syntax

marcinwyszynski commented 8 years ago

Wouldn't it then make sense to remove all mentions of postgres from the code?

bradrydzewski commented 8 years ago

Postgres is mentioned in one line if code due to copy / paste. References in /vendor cannot be removed because those references exist in our project dependencies. Feel free to send a PR to remove the reference in the case statement in database.go if you feel strongly about it