search

lgvalle / Material-Animations

Android Transition animations explanation with examples.
MIT License
13.52k stars 2.47k forks source link

Update project #30

Closed IgorGanapolsky closed 8 years ago

IgorGanapolsky commented 8 years ago

Updated gradle version. Updated gradle plugin version. Used static analysis to fix lint errors. Added .gitignore files.

lgvalle commented 8 years ago

Hi, can you please provide a description for this PR?

IgorGanapolsky commented 8 years ago

@lgvalle done

lgvalle commented 8 years ago

Hi @IgorGanapolsky, sorry for the delay. I appreciate your time and effort to make these lint checks fixes and I'm happy to merge them.

However I prefer to keep gradle build tools at latest stable version (1.5.0 today) I know 2.0.0-alpha8 is working fine for this demo project, but it will be outdated in the near future and is not really adding any value on a project like this.

If you want to amend the PR to keep it at 1.5.0 I'll just merge afterwards.

Otherwise I can merge as it is and change it myself. Whatever you prefer.

IgorGanapolsky commented 8 years ago

If you can merge and change yourself, that would be best.

@lgvalle Thanks and keep up the good work. @changetip $1 On Feb 8, 2016 2:52 PM, "Luis G. Valle" notifications@github.com wrote:

Hi @IgorGanapolsky https://github.com/IgorGanapolsky, sorry for the delay. I appreciate your time and effort to make these lint checks fixes and I'm happy to merge them.

However I prefer to keep gradle build tools at latest stable version ( 1.5.0 today) I know 2.0.0-alpha8 is working fine for this demo project, but it will be outdated in the near future and is not really adding any value on a project like this.

If you want to amend the PR to keep it at 1.5.0 I'll just merge afterwards.

Otherwise I can merge as it is and change it myself. Whatever you prefer.

— Reply to this email directly or view it on GitHub https://github.com/lgvalle/Material-Animations/pull/30#issuecomment-181495417 .

changetip commented 8 years ago

Hi @lgvalle, @IgorGanapolsky sent you a tip worth 2,674 bits ($1.00), and I'm here to deliver it ➔ collect your tip.

Learn more about ChangeTip