lgyers / firephp

Automatically exported from code.google.com/p/firephp
0 stars 0 forks source link

Allow explicit wrapping of logging data #30

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Log messages should support wrapping on a newline (\n) character in all
standard log styles as well as tables.

Original issue reported on code.google.com by christop...@gmail.com on 13 Sep 2008 at 8:38

GoogleCodeExporter commented 9 years ago

Original comment by christop...@gmail.com on 20 Sep 2008 at 3:14

GoogleCodeExporter commented 9 years ago

Original comment by christop...@gmail.com on 22 Sep 2008 at 8:54

GoogleCodeExporter commented 9 years ago
Fixed in 0.2 BETA

Original comment by christop...@gmail.com on 1 Oct 2008 at 6:33

GoogleCodeExporter commented 9 years ago

Original comment by christ...@christophdorn.com on 22 Oct 2008 at 5:12

GoogleCodeExporter commented 9 years ago
This doesn't appear to be fixed.  I'm running 0.2.0 in FF and the same on the 
server.
 Trying with ->info and ->log() with \r\n, \r or \n, none of them will produce a
newline in the output on FirePHP/Firebug.

Original comment by clint.priest on 23 Oct 2008 at 3:28

GoogleCodeExporter commented 9 years ago
This doesn't appear to be fixed.  I'm running 0.2.0 in FF and the same on the 
server.
 Trying with ->info and ->log() with \r\n, \r or \n, none of them will produce a
newline in the output on FirePHP/Firebug.

Original comment by clint.priest on 23 Oct 2008 at 3:28

GoogleCodeExporter commented 9 years ago
After more testing it appears that this is not possible at this time. Not sure 
why I
had marked it as fixed.

Original comment by christ...@christophdorn.com on 23 Oct 2008 at 8:20

GoogleCodeExporter commented 9 years ago
http://n2.nabble.com/Use-%5Cr%5Cn-in-FirePHP%3A%3ATABLE-td1086966.html#a1678152

I wrote a small patch to RequestProcessor.js for supporting newline inside 
table cells.
It split cells content in line on "\n" character and display them using a "<br 
/>"
hmtl tag.

I attach a diff file so, if you want, you can patch official sources in this way

Original comment by christ...@christophdorn.com on 19 Dec 2008 at 6:46

Attachments:

GoogleCodeExporter commented 9 years ago
Hi, 
I've tried patching the file but I got this error:

The patch seems to be outdated! The line 
TR({},
and the patchline
}
do not match. 

I'd really appreciate it if you could attach the patched file. 

Thanks

Original comment by sola.aj...@gmail.com on 14 Feb 2009 at 4:55

GoogleCodeExporter commented 9 years ago

Original comment by christ...@christophdorn.com on 14 Apr 2009 at 5:59

GoogleCodeExporter commented 9 years ago

Original comment by christ...@christophdorn.com on 14 Apr 2009 at 6:04

GoogleCodeExporter commented 9 years ago

Original comment by christ...@christophdorn.com on 14 Apr 2009 at 6:04

GoogleCodeExporter commented 9 years ago
Is it planned to be fixed? This makes firePHP not usable as logger in our team.

Original comment by Ged...@gmail.com on 22 Jul 2010 at 9:04

GoogleCodeExporter commented 9 years ago
This will be fixed in FireConsole: http://www.fireconsole.org/

In the meantime you could see if it works in FirePHP Companion. If not I can 
make a fix there right away.

http://companion.firephp.org/

Original comment by christ...@christophdorn.com on 22 Jul 2010 at 10:13

GoogleCodeExporter commented 9 years ago
I would be happy to see this change in FirePHP plugin, would it be difficult?

Original comment by marcinfi...@gmail.com on 27 Jul 2010 at 1:53

GoogleCodeExporter commented 9 years ago
Yes, it is difficult, which is why it will not make it into the FirePHP 
extension. It will be implemented in FireConsole which will replace the FirePHP 
extension later this year.

Original comment by christ...@christophdorn.com on 27 Jul 2010 at 4:29

GoogleCodeExporter commented 9 years ago
See: https://github.com/firephp/firephp-extension/issues/4

Original comment by christ...@christophdorn.com on 6 Apr 2012 at 9:31