search

lgyers / firephp

Automatically exported from code.google.com/p/firephp
0 stars 0 forks source link

PHP error notices running demos #33

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Running both the procedural and oo demos, got E_NOTICE errors (which I have
enabled). Fix attached.

Original issue reported on code.google.com by hfue...@gmail.com on 16 Sep 2008 at 4:47

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by christop...@gmail.com on 16 Sep 2008 at 5:15

GoogleCodeExporter commented 9 years ago

Original comment by christop...@gmail.com on 22 Sep 2008 at 9:45

GoogleCodeExporter commented 9 years ago 
I did not notice there is already a patch available, so I fixed this, too.
I used empty() instead of isset() and the patch contains the filename to patch 
for
easy merging.

Original comment by everf...@gmail.com on 23 Sep 2008 at 9:14

Attachments:

GoogleCodeExporter commented 9 years ago 
Fixed in 0.2 BETA

Original comment by christop...@gmail.com on 1 Oct 2008 at 6:33

GoogleCodeExporter commented 9 years ago 
I've just installed FirePHP 0.2.b.2 extension, and PEAR package 0.2.0beta4

And there are still some NOTICE errors. 
Detected under my PEAR::Log driver proposal
(http://pear.php.net/pepr/pepr-proposal-show.php?id=578), with the backtrace 
example.

Here are the two lines 517-518 fixed (to avoid notice errors)

'File'=>$this->_escapeTraceFile(isset($trace[$i]['file'])?$trace[$i]['file']:'')
,
                          'Line'=>isset($trace[$i]['line'])?$trace[$i]['line']:'',

Original comment by laurent....@gmail.com on 14 Oct 2008 at 9:29

GoogleCodeExporter commented 9 years ago 
Will be fixed in BETA 5. Thanks!

Original comment by christ...@christophdorn.com on 14 Oct 2008 at 10:31

GoogleCodeExporter commented 9 years ago

Original comment by christ...@christophdorn.com on 22 Oct 2008 at 5:11