lh3 / miniprot

Align proteins to genomes with splicing and frameshift
https://lh3.github.io/miniprot/
MIT License
310 stars 16 forks source link

Report errors mapping amino acids #40

Closed kdm9 closed 1 year ago

kdm9 commented 1 year ago

Hi Heng,

Thanks for yet another brilliant tool!

This patch reports errors mapping amino acid files to the reference. AFAICT, the only non-zero exit code of mp_map_file() is for errors opening the faa file(s). I hit this due to a stupid error on my part: giving query.faa.gz when only query.faa existed on disk. Miniprot ran fine but of course gave an empty gff. Now, the user should at least get a warning and a non-zero exit code in case of stupidity :)

Best, Kevin

lh3 commented 1 year ago

Make sense. Thanks!