Adding some structure to the code

lh3 / seqtk

Toolkit for processing sequences in FASTA/Q formats

MIT License

1.35k stars 311 forks source link

Adding some structure to the code #129

Closed kounkou closed 5 years ago

kounkou commented 5 years ago

Hi @lh3

Amazing project. I did some modifications to the code, The pull request adds some structure to the code by adding headers and decoupling constants from implementation. No functionality is impacted. Please don't hesitate if you see anything I can improve. This commit fixes #130

Best

lh3 commented 5 years ago

Thanks, but seqtk is not intended to be used as a library. Also, seq_nt16_table etc should not be defined in a header.

kounkou commented 5 years ago

closing it was fast... I had no intention of making seqtk a library. I truly believe decoupling the headers could help contributors have a quick insight over the different functions instead of having everything bundled in the .c