lhapaipai / symfony-vite-dev

Monorepo for symfony-vite development
https://symfony-vite.pentatrion.com
Other
27 stars 22 forks source link

Profiler error #40

Closed D3strukt0r closed 2 months ago

D3strukt0r commented 2 months ago

vite-plugin-symfony version

7.0.3

vite-bundle version

7.0.3

your OS, node version, Symfony version, PHP version

Debian Docker Container, Node 18.20.4, Symfony 6.4.10, PHP 8.3.10

Description

I just tried to upgrade from 6.5.0 to 7.0.3 without changing any other config, and now the profiler bar won't load.

image

When I check the URL where the 500 happened (https://project.test/_wdt/101c50), I get the error "An exception has been thrown during the rendering of a template ("Unable to generate a URL for the named route "_profiler_vite" as such route does not exist.")."

image

The profiler URL still works though (https://project.test/_profiler/a9a6f9?panel=pentatrion_vite.vite_collector&type=request)

image

How to reproduce

Dunno, I just updated. Maybe because we are still using Symfony 6.4 for this project?

Possible Solution

No response

lhapaipai commented 2 months ago

Hi @D3strukt0r, This is a major version change, this means there may be changes on your part to make

check the migration v7 guide. you have to update the recipe and make updates manually.

D3strukt0r commented 2 months ago

ah thanks, sorry didn't see that, i'll close if it worked

D3strukt0r commented 2 months ago

Ok worked, thanks :)

but shouldn't that change for the routes/pentatrion_vite.yaml be in the recipes? @lhapaipai

lhapaipai commented 2 months ago

the update is in the recipe but indeed. you are in a case where it did not update you.

check the pr : https://github.com/symfony/recipes-contrib/pull/1652

I had created a temporary version 6.5 just long enough for the pr of the symfony recipe to be accepted so that the recipe would already be merged on the day of v7 (that was the original intention). But as a result, it took me longer to release v7, people migrated to v6.5 and although the config/routes/pentatrion_vite.yaml file changed between v6.5 and v7, the recipe does not apply a second time. Sorry, I will know for next time

jeremyVignelles commented 2 months ago

Thanks for the thread, I faced the same issue today.

Can this issue be pinned for a while so that people like me migrating and wondering could find this more easily ? (I know it's in the migration docs, but it can sometimes be easier to find on the issues page).