search

lhapaipai / symfony-vite-dev

Monorepo for symfony-vite development
https://symfony-vite.pentatrion.com
Other
19 stars 19 forks source link

Fix Vue dependency - Refactor directory structure for stimulus helpers #8

Closed santos-pierre closed 6 months ago

santos-pierre commented 6 months ago

Was stuck with the same issue, was forced to install vue to avoid the error. I followed @dotdevpro's suggestion to put the registered functions in their own folder for each framework, and it works like a charm in the playground even if I delete the vue dependency. Copy-pasting the 'dist' folder into my current project also works fine.

netlify[bot] commented 6 months ago

Deploy Preview for cosmic-bubblegum-aa631a failed.

Name Link
Latest commit d5d31b4bdeaffe26515098b842151bf8bffbd83d
Latest deploy log https://app.netlify.com/sites/cosmic-bubblegum-aa631a/deploys/6580954292045e0008ba68fb
lhapaipai commented 6 months ago

hi @santos-pierre, thank you for your PR. This also seems to me to be the right solution. Can you explain to me why have you deleted the `src/vite-plugin-symfony/src/stimulus/helpers/vue.ts file ?

moreover the tsup config refers to a non-existent path : src/stimulus/helpers/vue/index.ts

finally could you update the english documentation ? docs/src/stimulus/symfony-ux.md

Have a good day

santos-pierre commented 6 months ago

Hello @lhapaipai,

My bad for the removal of the src/stimulus/helpers/vue/index.ts file. I forgot to include the new version. I have created a 'vue' folder and placed an 'index.ts' file inside it with the same content as the original src/stimulus/helpers/vue/index.ts file to maintain the same structure for each framework.

Hope it's good now (I always feel stressed out when doing a PR ^^).

lhapaipai commented 6 months ago

Thank you very mutch @santos-pierre ! it's perfect ! now it's up to me to struggle with the github workflow and the symfony UX dependencies which are in the vendor folder... :-)