lhcb / glossary

LHCb Glossary
https://lhcb.github.io/glossary
Creative Commons Attribution 4.0 International
11 stars 16 forks source link

Adding new terms #49

Closed lukascalle closed 2 years ago

lukascalle commented 2 years ago

New terms:

modified:

from Lera's fork, simulation related terms:

eduardo-rodrigues commented 2 years ago

Brilliant, thanks very much for this update 👍 ! Will look asap ...

eduardo-rodrigues commented 2 years ago

(BTW, we should really move to GHAs but that's a totally different matter.)

eduardo-rodrigues commented 2 years ago

(Do not forget to tick off what will be dealt with in issue https://github.com/lhcb/glossary/issues/36 and possibly in some of the other open ones.)

lukascalle commented 2 years ago

I think I've implemented all your comments and suggestions. Can I resolve the corresponding threads?

eduardo-rodrigues commented 2 years ago

I think I've implemented all your comments and suggestions. Can I resolve the corresponding threads?

Yes you should feel totally free to resolve when your commits ... resolve :-).

eduardo-rodrigues commented 2 years ago

Thanks again @lukascalle for this big update. Super appreciated! I'm now merging with my final edits. Indeed this is largely ready and we can always fine-tune "forever".

eduardo-rodrigues commented 2 years ago

Hey @henryiii, deployment failed after I merged this, see https://app.travis-ci.com/github/lhcb/glossary/builds/240225599. Comparing to the previous merge on master I see that that that one deployed just fine "as you", see https://app.travis-ci.com/github/lhcb/glossary/builds/217622626. Any idea on what happened in the meantime? Just a token that expired? I could not find one. Thanks for any pointer/help.

henryiii commented 2 years ago

GH replaced their tokens with a more secure format a little while back. I'm sure this was one of the old ones. Might be a good time to move to GHA?

eduardo-rodrigues commented 2 years ago

Indeed I mentioned above that we should move to GHAs, yes. I hope the format of the YAML is just about the same. Can give it a go. Thanks.