Closed lukascalle closed 2 years ago
Brilliant, thanks very much for this update 👍 ! Will look asap ...
(BTW, we should really move to GHAs but that's a totally different matter.)
(Do not forget to tick off what will be dealt with in issue https://github.com/lhcb/glossary/issues/36 and possibly in some of the other open ones.)
I think I've implemented all your comments and suggestions. Can I resolve the corresponding threads?
I think I've implemented all your comments and suggestions. Can I resolve the corresponding threads?
Yes you should feel totally free to resolve when your commits ... resolve :-).
Thanks again @lukascalle for this big update. Super appreciated! I'm now merging with my final edits. Indeed this is largely ready and we can always fine-tune "forever".
Hey @henryiii, deployment failed after I merged this, see https://app.travis-ci.com/github/lhcb/glossary/builds/240225599. Comparing to the previous merge on master I see that that that one deployed just fine "as you", see https://app.travis-ci.com/github/lhcb/glossary/builds/217622626. Any idea on what happened in the meantime? Just a token that expired? I could not find one. Thanks for any pointer/help.
GH replaced their tokens with a more secure format a little while back. I'm sure this was one of the old ones. Might be a good time to move to GHA?
Indeed I mentioned above that we should move to GHAs, yes. I hope the format of the YAML is just about the same. Can give it a go. Thanks.
New terms:
modified:
from Lera's fork, simulation related terms: