search

lhcb / glossary

LHCb Glossary
https://lhcb.github.io/glossary
Creative Commons Attribution 4.0 International
11 stars 16 forks source link

Added new defintions #53

Closed vlukashenko closed 2 years ago

vlukashenko commented 2 years ago

Adding definitions of BPV, CLARO, Delphes, GBTx, HPD, MaPMT, MiniDAQ, ODIN, PCIe40, Readout board, sODIN, SOL40, sWeights, TELL40, TFC, Timepix, Tracker-only, VeloPix

Crediting also Robbert Geertsema for a great review of the Timepix and Velopix definitions.

I am not really sure but some github ci test for creating a github book fails because I don't have some token...

eduardo-rodrigues commented 2 years ago

Thanks for this! So I guess that we should tick off some bits at least in https://github.com/lhcb/glossary/issues/34, potentially in other open issues (to be checked)?

vlukashenko commented 2 years ago

Thanks for this! So I guess that we should tick off some bits at least in #34, potentially in other open issues (to be checked)?

No problem! Will tick off :) Oh.. maybe I am not allowed to do that.

eduardo-rodrigues commented 2 years ago

I am not really sure but some github ci test for creating a github book fails because I don't have some token...

I see that as well. The GHA repository does not provide much help. Let's see if the issue remains when we are closer to getting this MR read ...

eduardo-rodrigues commented 2 years ago

(Feel free to resolve my suggested changes above if you made the changes yourself - in general the easiest is to simply accept if happy, and you can even do the commits in a single batch.)

eduardo-rodrigues commented 2 years ago

The CI failure is strange. I'm going to make a simple MR only adding the definition of ASIC to check if the problem really is somewhere in the changes of the MR or it's a more general one ...

vlukashenko commented 2 years ago

The CI failure is strange. I'm going to make a simple MR only adding the definition of ASIC to check if the problem really is somewhere in the changes of the MR or it's a more general one ...

Probably that last HPD link was an issue.

eduardo-rodrigues commented 2 years ago

The CI failure is strange. I'm going to make a simple MR only adding the definition of ASIC to check if the problem really is somewhere in the changes of the MR or it's a more general one ...

Probably that last HPD link was an issue.

I suspect so. Found it after I made that MR # 54 and started reviewing from top to bottom.

eduardo-rodrigues commented 2 years ago

Superseeded by https://github.com/lhcb/glossary/pull/54.