search

lhcb / glossary

LHCb Glossary
https://lhcb.github.io/glossary
Creative Commons Attribution 4.0 International
11 stars 16 forks source link

Add definitions starterkit #55

Closed vlukashenko closed 2 years ago

vlukashenko commented 2 years ago

Added an ntuple definition for Starterkit. @eduardo-rodrigues

eduardo-rodrigues commented 2 years ago

Thanks for this. I will look into the CI failure, which seems to be the same as got in your previous MR :S.

BTW, you ought to link to TTree, https://root.cern/doc/master/classTTree.html, not the rather shortly scoped TNutple, which we do not even use (for obvious reasons).

vlukashenko commented 2 years ago

Thanks for this. I will look into the CI failure, which seems to be the same as got in your previous MR :S.

BTW, you ought to link to TTree, https://root.cern/doc/master/classTTree.html, not the rather shortly scoped TNutple, which we do not even use (for obvious reasons).

I think the failure is connected to the secrets, where there is a PERSONAL_TOKEN uploaded. I am not entirely sure whether it is okay for non-personal projects. https://github.com/lhcb/glossary/settings/secrets/actions

eduardo-rodrigues commented 2 years ago

I think the failure is connected to the secrets, where there is a PERSONAL_TOKEN uploaded. I am not entirely sure whether it is okay for non-personal projects. https://github.com/lhcb/glossary/settings/secrets/actions

But then why does it work for me and not for you? And various other people committed. Dunno if somebody of the admins has an idea?

vlukashenko commented 2 years ago

I think the failure is connected to the secrets, where there is a PERSONAL_TOKEN uploaded. I am not entirely sure whether it is okay for non-personal projects. https://github.com/lhcb/glossary/settings/secrets/actions

But then why does it work for me and not for you? And various other people committed. Dunno if somebody of the admins has an idea?

I can try to upload my token there now and see what will happen then

eduardo-rodrigues commented 2 years ago

Closing in favour of the more complete https://github.com/lhcb/glossary/pull/56.