search

lhcb / second-analysis-steps

Level two LHCb data analysis lessons
https://lhcb.github.io/second-analysis-steps/
3 stars 20 forks source link

braindump on compiling your own packages #11

Closed pseyfert closed 4 years ago

pseyfert commented 8 years ago

really just a brain dump. deserves extension.

pseyfert commented 8 years ago

doesn't build -> don't care for now indeed i missed the overlap with first-... /15-... since i filtered only on "Setup" but seems the overlap turns out rather small anyhow.

pseyfert commented 8 years ago

is it actually common sense to advise what i wrote (check out your analysis package and add it to DV via cmt/requirements) or is it preferred to getpack Phys/DecayTreeTuple and copy all files there (after having getpack'ed them from the analysis package)?

pseyfert commented 8 years ago

Just discovered the masterpackage property of ganga's DaVinci class. The documentation looks like this is the intended way of adding private packages instead of manipulating Phys/DaVinci/cmt/requirements (like I suggest in the PR). Can anybody confirm?

pseyfert commented 8 years ago 
The command "[ "${TRAVIS_PULL_REQUEST}" = "false" ] && make publish-travis > /dev/null 2>&1 || true" exited with 0.
0.11s$ make check
python tools/check.py .
Traceback (most recent call last):
  File "tools/check.py", line 841, in <module>
    main(parsed_args)
  File "tools/check.py", line 825, in main
    res = validate_single(fn, template=template)
  File "tools/check.py", line 708, in validate_single
    validate_file = validator(filepath)
  File "tools/check.py", line 66, in __init__
    ast = self._parse_markdown(self.markdown)
  File "tools/check.py", line 73, in _parse_markdown
    parser = CommonMark.DocParser()
AttributeError: 'module' object has no attribute 'DocParser'
make: *** [check] Error 1

i claim this is a fault of the test suit and not of my pr.

pseyfert commented 4 years ago

closing all my cern related PRs as won't-pursue-anymore w/o checking status