search

lhcb / starterkit-lessons

Lessons taught at the Starterkit workshops.
https://lhcb.github.io/starterkit-lessons/
Other
35 stars 91 forks source link

Compatibility of DaVinci and Analysis in LHCb software development lesson and update of DaVinci version #297

Open vlukashenko opened 1 year ago

vlukashenko commented 1 year ago

here it looks like DaVinci/v45r8 would not be anymore compatible with whatever the changes happened in Analysis.

lb-dev DaVinci/v45r8
lb-use Analysis
git lb-checkout Analysis/run2-patches Phys/DecayTreeTuple

will result in 

CMake Error at Phys/DecayTreeTuple/CMakeLists.txt:94 (gaudi_install):
  Unknown CMake command "gaudi_install".

It seems that the DaVinci/v46r8 works though - but then need to change the DaVinci version everywhere and check that commands are still working.

Thanks to Emily Kaiyin Jiang for spotting this.

jpwgnr commented 1 month ago

Hi, I would prefer here to switch to 

git lb-checkout Analysis/v21r8 Phys/DecayTreeTuple

as Analysis/v21r8 corresponds to DaVinci/v45r8.

I think this fix is easier than changing DaVinci in the whole tutorial.