Test all branches. - Githubissues

lhcb / starterkit

Central website for all efforts related to the LHCb Starterkit.

https://lhcb.github.io/starterkit

MIT License

7 stars 8 forks source link

Test all branches. #20

Closed alexpearce closed 8 years ago

alexpearce commented 8 years ago

Travis ignore gh-pages branch by default, see travis-ci/travis-ci#476.

kdungs commented 8 years ago

But that's fine, no? As long as your fork uses a different branch name. Well okay maybe it's better to have this in for convenience.

kdungs commented 8 years ago

Gem::InstallError: public_suffix requires Ruby version >= 2.0.
An error occurred while installing public_suffix (1.5.3), and Bundler cannot
continue.
Make sure that `gem install public_suffix -v '1.5.3'` succeeds before bundling.
The command "bundle install" failed and exited with 5 during .
Your build has been stopped.

betatim commented 8 years ago

Drive by comment: 🎊 ㊗️ 🎆 🏆 ... 🚙 💨

alexpearce commented 8 years ago

But that's fine, no?

Apparently not. My previous PR wasn't building, nor was the merge commit in master. It's building now, so I'm assuming it's necessary.

Drive by comment

🙇

kdungs commented 8 years ago

LGTM