search

lhe17 / nebula

GNU General Public License v2.0
26 stars 6 forks source link

Update indexing type for Eigen 3.4 compatibility #41

Closed andrjohns closed 1 week ago

andrjohns commented 5 months ago

This PR updates your package's C++ to use an integer vector (Eigen::VectorXi) instead of a doubles vector (Eigen::VectorXd) for storing indexing values, otherwise your package will break with the next RcppEigen release.

Let me know if you have any questions, thanks!

lhe17 commented 4 months ago

Dear Andrew,

Thank you very much for your notification and revision. I've now incorporated all your modifications into the lastest version 1.5.3. I'll submit this version to CRAN in a couple days.

Best regards, Liang

On Tue, Jan 16, 2024 at 1:02 PM Andrew Johnson @.***> wrote:

This PR updates your package's C++ to use an integer vector ( Eigen::VectorXi) instead of a doubles vector (Eigen::VectorXd) for storing indexing values, otherwise your package will break with the next RcppEigen release.

Let me know if you have any questions, thanks!

You can view, comment on, or merge this pull request online at:

https://github.com/lhe17/nebula/pull/41 Commit Summary

File Changes

(2 files https://github.com/lhe17/nebula/pull/41/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/lhe17/nebula/pull/41, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGDISURYUNU4DO5ZJQNK54TYO26BPAVCNFSM6AAAAABB5HMZXSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4DINJTGUZDKNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

eddelbuettel commented 4 months ago

It is already on CRAN! Many thanks for the speedy update!

image