lheagy / simpegem

A electromagnetic forward modelling and inversion package for SimPEG.
MIT License
2 stars 1 forks source link

Pulling EM into Base SimPEG? #31

Closed rowanc1 closed 9 years ago

rowanc1 commented 9 years ago

We were chatting through merging a few of the more mature packages, this allows people to download one package and have all of everything in one place.

I think EM is getting to the stage where we can merge it in. MT depends on EM and SimPEG and this gets pretty complicated in terms of which versions things are running on.

@sgkang, @grosenkj, @bsmithyman, @lheagy thoughts?

Ideally, as soon as the major physics and data processing bits of each package are ready, we could move them in, and present a united front to the world. :)

-R

lheagy commented 9 years ago

I agree! We are advocating for having all of these problems in a common framework and easily accessible, so lets put them all in one place.

Should we do that this week??

grosenkj commented 9 years ago

I like this idea. It will make everything much easier (maintenance, testing and fostering the codes). It would also help solving the dependency issue of the codes.

We need to smart about where we put things, especially in the name space. Might be a good idea to only allow the something like this:

from SimPEG(.packages) import MT, FDEM, ...

when import the specific packages. Then this

import SimPEG 

would only import for base functionality of SimPEG. That would make the SimPEG namespace smaller and concise.

I am exited about this development and hope to get the MT package integrated asap.

bsmithyman commented 9 years ago

Seems like a good idea. Obviously my stuff is at a very early stage, but for the codes that are more developed it seems sensible. Alternatively, Git supports “submodules”, which I’ve never used, but might be a way to tie things together without losing all the commit history from the development projects. https://git-scm.com/book/en/v2/Git-Tools-Submodules https://git-scm.com/book/en/v2/Git-Tools-Submodules

On Aug 5, 2015, at 11:46 PM, Gudni Karl Rosenkjaer notifications@github.com wrote:

I like this idea. It will make everything much easier (maintenance, testing and fostering the codes). It would also help solving the dependency issue of the codes.

We need to smart about where we put things, especially in the name space. Might be a good idea to only allow the something like this:

from SimPEG(.packages) import MT, FDEM, ... when import the specific packages. Then this

import SimPEG would only import for base functionality of SimPEG. That would make the SimPEG namespace smaller and concise.

I am exited about this development and hope to get the MT package integrated asap.

— Reply to this email directly or view it on GitHub https://github.com/simpeg/simpegem/issues/31#issuecomment-128227101.

rowanc1 commented 9 years ago

We are planning to do this on Wednesday Nov 4.

rowanc1 commented 9 years ago

This issue was moved to simpeg/simpeg#155