search

lhenneman / hyspdisp

4 stars 4 forks source link

Functions have possibly too many arguments. #24

Closed schoolAccountMajaG closed 5 years ago

schoolAccountMajaG commented 5 years ago

It is a bit confusing to understand all the arguments in the functions at first. Could we rewrite some things?

schoolAccountMajaG commented 5 years ago

https://github.com/lhenneman/hyspdisp/blob/master/vignettes/hyads.Rmd#L242-L251 here is an example example. What do you think?

I also got confused with https://github.com/lhenneman/hyspdisp/blob/master/vignettes/hyads.Rmd#L219-L228 when trying to debug

cchoirat commented 5 years ago

Second link should be https://github.com/lhenneman/hyspdisp/blob/master/vignettes/hyads.Rmd#L219-L228

schoolAccountMajaG commented 5 years ago

Tried to reduce as much as possible but it was difficult. New functions and arguments implemented in disperseR