Unknown source of error in vignette

[schoolAccountMajaG]

while running https://github.com/garbulinskamaja/hyspdisp/blob/master/vignettes/hyads.Rmd#L241-L251

[schoolAccountMajaG]

Follow up: This is a tree of errors:

_Error in link_zip(d = dtrim, zc = zcta2, cw = crosswalk, gridfirst = T, : unused argument (gridfirst = T)

while running this https://github.com/lhenneman/hyspdisp/blob/master/R/hyspdisp_zip_link.R#L102-L106.

if we write >if( gridfirst != T){ instead of >if( gridfirst == F){ here: https://github.com/lhenneman/hyspdisp/blob/master/R/link_zip.R#L35 it seems to work fine.

[cchoirat]

https://stat.ethz.ch/R-manual/R-devel/library/base/html/Logic.html

It's better to stay away from code such as gridfirst == F, side-effects can be quite unexpected. isFALSE(gridfirst) might be a better way to go.

On Fri, Jun 14, 2019 at 3:40 PM Maja notifications@github.com wrote:

Follow up: This is a tree of errors:

Error in link_zip(d = d_trim, zc = zcta2, cw = crosswalk, gridfirst = T, : unused argument (gridfirst = T)

while running this https://github.com/lhenneman/hyspdisp/blob/master/R/hyspdisp_zip_link.R#L102-L106 .

if we write >if( gridfirst != T){ instead of >if( gridfirst == F){ here: https://github.com/lhenneman/hyspdisp/blob/master/R/link_zip.R#L35 it seems to work fine.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lhenneman/hyspdisp/issues/38?email_source=notifications&email_token=AA73AZNHLPRIDB2VMEJRUBDP2ONTNA5CNFSM4HYHSTRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXW2HAA#issuecomment-502113152, or mute the thread https://github.com/notifications/unsubscribe-auth/AA73AZLHRGZWQAJMEKNZP53P2ONTNANCNFSM4HYHSTRA .

[schoolAccountMajaG]

Thanks a lot!

[schoolAccountMajaG]

I am still getting a tree of errors "scheduled cores 3 encountered errors in user code, all values of the jobs will be affected" trying to run https://github.com/garbulinskamaja/hyspdisp/blob/master/vignettes/hyads.Rmd#L241-L251. @lhenneman can you please see if the vignette code works well for you?

[lhenneman]

The vignette works for me. Try looking at linked_zips1. It should give some clue what the errors are.

On Fri, Jun 14, 2019 at 10:36 AM Maja notifications@github.com wrote:

I am still getting a tree of errors "scheduled cores 3 encountered errors in user code, all values of the jobs will be affected" trying to run https://github.com/garbulinskamaja/hyspdisp/blob/master/vignettes/hyads.Rmd#L241-L251. @lhenneman https://github.com/lhenneman can you please see if the vignette code works well for you?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lhenneman/hyspdisp/issues/38?email_source=notifications&email_token=AHMZYWZ4GVLUE3HMPFHLJVDP2OUH3A5CNFSM4HYHSTRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXW7I3Q#issuecomment-502133870, or mute the thread https://github.com/notifications/unsubscribe-auth/AHMZYW5QDWSJPXHLV4HRYYDP2OUH3ANCNFSM4HYHSTRA .

-- Lucas R.F. Henneman, Ph.D. (404) 788-2161 lhenneman@gmail.com

[schoolAccountMajaG]

I think we should try to install it on a clean machine. You must have something installed that I do not @lhenneman.

[cchoirat]

CI/CD via Travis CI is the way to go.

https://docs.travis-ci.com/user/languages/r/ https://juliasilge.com/blog/beginners-guide-to-travis/

On Mon, Jun 17, 2019 at 4:14 PM Maja notifications@github.com wrote:

I think we should try to install it on a clean machine. You must have something installed that I do not @lhenneman https://github.com/lhenneman.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lhenneman/hyspdisp/issues/38?email_source=notifications&email_token=AA73AZP2YZGAV2BZU6EO5DTP26L23A5CNFSM4HYHSTRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3JROY#issuecomment-502700219, or mute the thread https://github.com/notifications/unsubscribe-auth/AA73AZIJYGDJGIYGGYJIMATP26L23ANCNFSM4HYHSTRA .

[schoolAccountMajaG]

@lhenneman can you please add ")" https://github.com/lhenneman/SplitR/blob/master/R/hysplit_dispersion.R#L721 in this line.

" GIS_part_*.csv)"))

[lhenneman]

Good catch! Fixed.

On Wed, Jul 3, 2019 at 8:05 AM Maja notifications@github.com wrote:

@lhenneman https://github.com/lhenneman can you please add ")" https://github.com/lhenneman/SplitR/blob/master/R/hysplit_dispersion.R#L721 in this line.

" GISpart*.csv)"))

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lhenneman/hyspdisp/issues/38?email_source=notifications&email_token=AHMZYW364HVAUWMU4Z4Y63LP5SIYRA5CNFSM4HYHSTRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZEHJHQ#issuecomment-508064926, or mute the thread https://github.com/notifications/unsubscribe-auth/AHMZYW7U5UVEXR5ZIUP2G7LP5SIYRANCNFSM4HYHSTRA .

-- Lucas R.F. Henneman, Ph.D. (404) 788-2161 lhenneman@gmail.com

[schoolAccountMajaG]

This has been debugged and fixed