search

lhenneman / hyspdisp

4 stars 4 forks source link

get_os function. What library? #50

Closed schoolAccountMajaG closed 4 years ago

schoolAccountMajaG commented 5 years ago

https://github.com/lhenneman/SplitR/blob/master/R/hysplit_dispersion.R#L358

I am going through the deepest layers of the code to find where my errors come from. This is a function that was not installed on my computer. Trying to find the package.

schoolAccountMajaG commented 5 years ago

@lhenneman https://github.com/lhenneman/SplitR/blob/master/R/hysplit_dispersion.R#L378-L417 do you think we could change this function? It is very confusing how the presence of the files is checked and it gives back errors. I say we should ask the user to downloaded the files before - using our datadownload function, which is now very simple, and delete the file download part from hysplit_dispersion. Can we do that?

lhenneman commented 5 years ago

Sounds like a great idea to me!

On Tue, Jul 2, 2019 at 10:25 AM Maja notifications@github.com wrote:

@lhenneman https://github.com/lhenneman https://github.com/lhenneman/SplitR/blob/master/R/hysplit_dispersion.R#L378-L417 do you think we could change this function? It is very confusing how the presence of the files is checked and it gives back errors. I say we should ask the user to downloaded the files before using our datadownload function, which is now very simple, and delete the file download part from hysplit_dispersion. Can we do that?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lhenneman/hyspdisp/issues/50?email_source=notifications&email_token=AHMZYW5UP63VEQ7QP2XFFULP5NQL3A5CNFSM4H44IJGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZBONLI#issuecomment-507700909, or mute the thread https://github.com/notifications/unsubscribe-auth/AHMZYWZVOQ4VBOLZJPAMNNLP5NQL3ANCNFSM4H44IJGA .

-- Lucas R.F. Henneman, Ph.D. (404) 788-2161 lhenneman@gmail.com

lhenneman commented 5 years ago

More reason to keep using lhenneman/SplitR then I guess so we can make these changes.

On Wed, Jul 3, 2019 at 3:11 AM Maja notifications@github.com wrote:

The more I look at it, the more I think it should be rewritten. The system of how paths are managed is an issue. The function on my computer depends on get_os recognizing that I am using a "mac" but get_os outputs "osx" and then the paths are not written correctly. This happened to more people who wrote issues but the author of SplitR has not really been active.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lhenneman/hyspdisp/issues/50?email_source=notifications&email_token=AHMZYW7PMQRIS6RHV2TVDT3P5RGLLA5CNFSM4H44IJGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZDQGRQ#issuecomment-507970374, or mute the thread https://github.com/notifications/unsubscribe-auth/AHMZYW37AMYBXV4SBZMJ6YDP5RGLLANCNFSM4H44IJGA .

-- Lucas R.F. Henneman, Ph.D. (404) 788-2161 lhenneman@gmail.com

schoolAccountMajaG commented 5 years ago

There are a few changes I want to make. Is it ok if I add a hysplit_dispersion2 function to hyspdisp instead of forking it?

lhenneman commented 5 years ago

Okay with me.

On Wed, Jul 3, 2019 at 9:51 AM Maja notifications@github.com wrote:

There are a few changes I want to make. Is it ok if I add a hysplit_dispersion2 function to hyspdisp instead of forking it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lhenneman/hyspdisp/issues/50?email_source=notifications&email_token=AHMZYWZQTVXUMJSYN4PFU3DP5SVEPA5CNFSM4H44IJGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZEQKCI#issuecomment-508101897, or mute the thread https://github.com/notifications/unsubscribe-auth/AHMZYW6M53TMMXQDQ4JW37DP5SVEPANCNFSM4H44IJGA .

-- Lucas R.F. Henneman, Ph.D. (404) 788-2161 lhenneman@gmail.com

schoolAccountMajaG commented 4 years ago

get_os is defined in disperseR