Comments about dev2 - Githubissues

[ ] It seems that a specific version of SplitR is required:
```
install_github("lhenneman/SplitR")
```

[ ] In README example, date_ref_h should be using dates:

date_ref_h <- data.table( expand.grid( start_hour = c( 0, 6, 12, 18),
                                   start_day = seq.Date( from = as.Date("2005-01-01"),
                                                         length.out = 2,
                                                         by = '1 day'),
                                   duration_emiss_hours = 1,
                                   duration_run_hours = 10))

[x] I think you can replace

zcta_shapefile <- "~/Downloads/cb_2015_us_zcta510_500k/cb_2015_us_zcta510_500k.shp"
zcta <- shapefile( x = zcta_shapefile)`

with

library(tigris)
options(tigris_use_cache = TRUE)
zcta <- zctas(cb = TRUE, year = 2015)

[x] Typo:

zcta2 <- spTransform( x = zcta, 
                  CRSobs = p4s)

should be

zcta2 <- spTransform( x = zcta, 
                  CRS = p4s)

[ ] Is there a missing dependency on package ncdf4?

hpbl_rasterin <- rotate( brick( x = hpbl_file, 
                            varname = 'hpbl' ))

[ ] Can you explain why you need to rotate hpbl_rasterin?
[ ] Can you let users specify the numbers of cores?
```
l <- mclapply(seq_len( nrow( date_ref_h)), [...]
```
[ ] Can you let users specify a weather path?

[ ] l seems to contains errors:

# [[1]]
# [1] "Error in file(file, ifelse(append, \"a\", \"w\")) : \n  cannot open the connection\n"
# attr(,"class")
# [1] "try-error"
# attr(,"condition")
# <simpleError in file(file, ifelse(append, "a", "w")): cannot open the connection>

[ ] Can you explain better the structure of l and where to find the ZIP code level linkage?
[ ] Can the crosswalk file be part of the package?

lhenneman / hyspdisp

Comments about dev2 #9