lhespress / zigpy-espzb

GNU General Public License v3.0
28 stars 5 forks source link

More unit tests? #12

Open Hedda opened 7 months ago

Hedda commented 7 months ago

@lhespress Do you plan on writting additonal unit tests in this radio library for zigpy?

For reference please see the tests directory for the bellows, zigpy-znp, and zigpy-deconz radio libraries and add minimum:

puddly's reply in https://github.com/home-assistant/core/pull/114828 indicates lack of unit tests in radio library can be a showstopper for acceptance.

"Merging support for an untested package would introduce an enormous maintenance burden, as we would not be able to update zigpy without also fixing zigpy-zboss and testing it by hand."

Tip when adding tests suggest also checking Home Assistant's "Development Checklist" to make sure check all those boxes too:

PS: Copy to @Maxwelltoo, as you mentioned having an interest in helping out.