Patch for Eclipse and Findbugs warnings

[GoogleCodeExporter]

Patch to clean up Eclipse and Findbugs warnings.

Here's what was changed:
Removed wagon-svn plugin from POM; my maven cannot find this plugin (don't
recommend this as global change, it just got included in the file)

MemcachedCache:
Moved dogpile key generation to inside the if statement. This way, users
not using dogpile key will not try to generate it.
Removed extraneous else statement
Changed parseLong to valueOf to remove extraneous boxing

MemcachedCacheProvider:
Chained exceptions properly

DangaMemcacheClientFactory:
Exception chaining

StringUtils:
Removed extranous variable allocation (direct return instead)

Appreciate your consideration of the patch.

Original issue reported on code.google.com by jaso...@gmail.com on 30 Jul 2009 at 1:36

Attachments:

• 0001-Findbugs-and-Eclipse-warnings-cleanup.patch

[GoogleCodeExporter]

Think you could give github a try here? If you have a github account you can 
fork the
project at the click of a button and then send me a pull request when your 
changes
are complete. The great part of that is that you get the credit in the history 
of the
project. I pull commits in quickly, whereas with the patch file I gotta mess 
with the
code to get it to apply.

If not, that's fine I can get the patch in sooner or later.

Original comment by raykrue...@gmail.com on 30 Jul 2009 at 2:09

• Added labels: Priority-Low, Type-Enhancement
• Removed labels: Priority-Medium, Type-Defect

[GoogleCodeExporter]

Scratch that....

I'd really prefer to receive commits from folks via github. Please consider 
using git
in the future.

I've applied the patch you've provided, minus the pom.xml changes. If you were 
having
a problem with this in Eclipse you probably need to add the repositories from 
my pom
to your m2eclipse setup. It should work fine from the command line.

I did however remove the eclipse and idea plugins as they're pointless these 
days.

Original comment by raykrue...@gmail.com on 30 Jul 2009 at 2:10

[GoogleCodeExporter]

Committed
http://github.com/raykrueger/hibernate-memcached/tree/2cd965b7eb8a97efa50ab2709a
4c8b1606147c76

Original comment by raykrue...@gmail.com on 30 Jul 2009 at 2:13

• Changed state: Fixed

[GoogleCodeExporter]

I actually used git to generate the patch, so I'd be happy to submit changes 
that way
as well.

Original comment by jaso...@gmail.com on 30 Jul 2009 at 3:24