search

lhl2617 / VSLilyPond

VSCode Extension for LilyPond
https://marketplace.visualstudio.com/items?itemName=lhl2617.vslilypond
90 stars 7 forks source link

Restart midi input on port change #348

Closed paradox460 closed 2 years ago

paradox460 commented 2 years ago

In the current implementation, if you start a MIDI input session, and then change the device/port, your existing MIDI session will continue with the old device/port.

This ends that session and immediately starts a new one, effectively "restarting it."

JZZ was unclear if their package allows for changing a port while a read callback is running. Some other WebMIDI systems, such as webmidi.js, do allow for this.

lhl2617 commented 2 years ago

JZZ was unclear if their package allows for changing a port while a read callback is running. Some other WebMIDI systems, such as webmidi.js, do allow for this.

Would be nice if it did, but eh, let's do this for now. I'll add a command to restart MIDI input as well (with a reminder in the settings to restart it upon a port/device change).