search

lhmouse / mcfgthread

Cornerstone of the MOST efficient std::thread on Windows for mingw-w64
https://gcc-mcf.lhmouse.com/
Other
269 stars 28 forks source link

build: add build-test option #259

Open star-hengxing opened 3 weeks ago

lhmouse commented 3 weeks ago

There are two issues with this commit:

  1. The preferred name for this option would be enable-tests or with-tests (use plural!). The former is usually preferred.
  2. Tests should not be disabled by default. Ideally we should have build_by_default: false on tests, but it does not do what it seems to be: (https://github.com/mesonbuild/meson/issues/2518)