Closed chawyehsu closed 6 months ago
It's better to have this conversion in get_full_path()
, instead of just applying it to the path to home directory.
And I have it there now: https://github.com/lhmouse/nano-win/commit/ef33c2a8d638910861d2563d1ea75f5bf4407177#diff-57b320cc7adea8a7d492648179ebdd206bb8090f0b897e8965b0b482d0dbc88bR1247
That looks better. Thank you for the good work!
@lhmouse I've updated to the latest version of nano-win. It seems that your patches do not solve the issue I mentioned above. I'm reopening this, we need further discussion maybe.
Looks like the function calling stack in rcfile.c
did not call get_full_path()
:
parse_rcfile()
-> parse_includes()
-> parse_one_include()
-> real_dir_from_tilde()
-> get_homedir()
Patching get_full_path()
can not fix rcfiles including issue.
Yeah we have to do the same to the path returned by real_dir_from_tilde()
. I have a quick look at other functions that return char*
s: It looks like that these two functions (as well as get_full_path()
) may generate paths with slashes, while all the others just forward the result of them, so translating backslashes to forwardslashes in all results from them should suffice.
https://files.lhmouse.com/nano-win/nano-win_9371_v5.4-9-g8ad13081.7z
Maybe we can just use get_full_path()
inside the parse_one_include()
, instead of duplicating slashes replacement in real_dir_from_tilde()
.
I just committed the patch and found you've rebased the branch...
Really confused about branch rebasing, god.
get_full_path()
is actually calling real_dir_from_tilde()
everytime, therefore doing slashes replacement in real_dir_from_tilde()
only should be the minimal patch for all cases.
Edit: the function call
This whack-a-mole game isn't satisfactory, given the fact that paths in principle are very fragile (some of them come from environment variables such as HOME
, some others are hardcoded such as /tmp
, and there is no proper check for path separators other than /
at all).
Really confused about branch rebasing, god.
A preferred solution would be a standalone patch, such as https://github.com/lhmouse/nano-win/blob/master/ncurses-6.1.patch. But as GNU nano doesn't have a relatively stable working tree (the author really loves trivial changes such as renaming or deleting variables), this would result in a lot of conflicts frequently, and resolving git am
'd conflicts is really a nightmare. So, rebase only, then force-push. Historical snapshots can be pushed to other branches.
Looks like recent builds of nano-win breaked the slash fix, and did not handle ~/
includes anymore.
version: v5.6.1-51-g32071383
I should look into it later.
A new build has been uploaded at https://files.lhmouse.com/nano-win/nano-win_9605_v5.7-34-g387900675.7z.
closing stale pr.
This fixes the issue of including
nanorc
files whose path leads with a tilde.before:
~/.nanorc
~/.nano/nanorc.nanorc
was expanded toC:\Users\<username>/.nano/nanorc.nanorc
, and this doesn't work.after:
~/.nano/nanorc.nanorc
is expanded toC:/Users/<username>/.nano/nanorc.nanorc
, work as expected.