lhnguyen102 / cuTAGI

CUDA implementation of Tractable Approximate Gaussian Inference
MIT License
30 stars 9 forks source link

Fixing bugs #32

Closed miquelflorensa closed 1 year ago

miquelflorensa commented 1 year ago

In this PR I try to solve this to errors:

  1. In almost all tests there was missing a line that made that all weights and biases from the references were not taken into account when doing the comparison.
  2. In some cases, some of the backward hidden states weren’t read due to the way I made the read_from_csv function.

In addition, I'm trying a new way to compare the values by just cheking if the difference is less than a certain threshold.