search

lhnguyen102 / cuTAGI

CUDA implementation of Tractable Approximate Gaussian Inference
MIT License
24 stars 9 forks source link

Minor fixes to RegressionDataLoader and PredictionViz #40

Closed a-fakhri closed 6 months ago

a-fakhri commented 6 months ago

Description

  1. Data scaling was done using information from the test set. For more info about this issue: https://machinelearningmastery.com/data-preparation-without-data-leakage/
  2. Plot was not showing the std_factor used for the uncertainty about the predictions.

    Changes Made

  3. Fixed the RegressionDataLoader class to use only the training data for scaling.
  4. Fixed the plot_predictions method of the PredictionViz class to show the std_factor used in the plot.

    Note for Reviewers

    I tested the changes on Linux with the regression_runner.py file. There were issues with the imports of the modules caused by the folder structure. I had to move around some files to overcome this, but you might not experience it testing on Mac.