Closed van-dai-vuong closed 1 month ago
@van-dai-vuong That is definitely a bug. It should be delta_m_out
. Could you make a PR to correct it along with the cuda version. Thanks!
@lhnguyen102 I will do it
@van-dai-vuong cool. Btw, I will make a PR for including previous states for LSTM tonight
@lhnguyen102 thanks a lot
I was wondering if the code to update the LSTM's hidden states in the below function are correct. The
forget
,input
,cell state
gates usedelta_m
, whereas theoutput
gate usesdelta_m_out
?