lhnguyen102 / cuTAGI

CUDA implementation of Tractable Approximate Gaussian Inference

MIT License

31 stars 10 forks source link

Fix bugs estimating delta to update LSTM's hidden states #78

Closed van-dai-vuong closed 3 months ago

van-dai-vuong commented 3 months ago

Description

This PR fixes the bugs when estimating delta that needed to update the LSTM's hidden states and parameters in the backward pass.

Changes Made

In the files lstm_layer.cpp and lstm_layer_cuda.cu, I changed delta_m to delta_m_out in the lstm_delta_mean_var_z_worker functions.
I have tested by running time_series_forecasting.py with CPU and GPU.

Note for Reviewers

You can test by running time_series_forecasting.py