Closed nightroman closed 10 years ago
@nightroman Thank you ever so much for taking the time look through my integration with Invoke-Build, I'll make those changes you suggest above as a PR and send you a link to take and verify if that's ok?
I can make a PR with these changes, give me a day or two.
@nightroman Wow, that would be fantastic, I'll hold fire for now then. Thanks again
Please review the PR. In addition to the list above:
Write-Host
with Write-Output
All changes are completely up to you.
I was just passing by and noticed that you use Invoke-Build. I am glad to see this. May I recommend something in order to improve .build.ps1 a little bit?
You may remove
because this is done by Invoke-Build.
You may remove
and use the special Invoke-Build variable
$BuildRoot
instead of$basePath
.The line
causes a warning because Invoke-Build discourages output from the script scope. You may either remove this line or use
Write-Host
instead ofWrite-Output
.Write-Host
has disadvantages but it is used in two tasks anyway. If this is important to avoidWrite-Host
then use this codeThis function is called on every build before any task and writes output without a warning.
You may reformat your task comments so that
#* Purpose:
is replaced with# Synopsis:
. As a result, the commandwill show the task synopsis column populated with your comments (one line though).
Happy building!