search

lholman / OneBuild

Convention based PowerShell build for .NET http://lholman.github.io/OneBuild/
Apache License 2.0
17 stars 2 forks source link

Improvement for determining test file projects #16

Closed dashton82 closed 9 years ago

dashton82 commented 9 years ago

Hi,

Instead of the reliance of the your unit test project having the word nUnit in it, would it be possible to look at the project dependencies to see whether or not it has a reference to nunit.framework.dll? And if it does, query the project file or assume that the relating dll.config file name is the dll that contains your tests?

lholman commented 9 years ago

Hey Dan, my current priority is stability and simplicity, 'nunit' in the assembly name is a very simple way of defining an easily testable contract, at present I'd rather not complicate that with either passing '.xproj' or '.sln' config files which could be both expensive and fragile,or relying on other assumptions that may not be guaranteed. I'll be looking to support additional testing frameworks soon and I still feel this is as simple as I can get it. Unfortunately with any library/framework that is convention driven there is a trade off you need to take (I'd say this is one of the biggest with OneBuild), hopefully the benefit outweighs adhering to that convention? I'll close this for now, I hope that's fair, please do keep the suggestions coming, or set me straight ;-)