Open AwaNoodle opened 9 years ago
Yes, that seems fairly trivial to add to the New-Packages task and associated module. I can see the value if you're heavily leaning on NuGet packaging.
I see it adding to the current convention http://lholman.github.io/OneBuild/conventions.html that does the following:
"Generates new Nuget ([packageName].[version].nupkg) and optional Symbols({packageName].[version].symbols.nupkg) package(s) by passing all .nuspec files found in the solution root folder."
With the addition of..
"Generates new Nuget ([packageName].[version].nupkg) and optional Symbols({packageName].[version].symbols.nupkg) package(s) by identifying any .nuspec files under the solution root that contain the name of and are at the same level as a Visual Studio project file (.csproj..and?) with a corresponding name and then executing Nuget Pack for the VS project files."
A few thoughts..
I think csproj is the most likely to be used so I would ensure that is working. However, if you are scanning and matching on csproj adding a vbproj (if supported) isn't likely to cause a problem.
I like the idea of the symbols too. If someone has added the a symbols nuspec sitting next to the csproj then that seems a nice way to opt in.
Another option would be to support OctoPack for projects which have the target installed by specifying /p:RunOctoPack=true when invoking the compilation of the solution.
@AwaNoodle Does the merging of #36 (originally #31) solve this for you, if so, could you close?
Not fully. I won't always be using Octopack.
Ok, let's get early visibility of the PR so it's not a big surprise.
ll
-----Original Message----- From: "Mark Turner" notifications@github.com Sent: 09/02/2015 17:23 To: "lholman/OneBuild" OneBuild@noreply.github.com Cc: "Lloyd Holman" lloyd.holman@datumgenerics.net Subject: Re: [OneBuild] Automatically building nuspec files for csproj files(#27)
Not fully. I won't always be using Octopack. — Reply to this email directly or view it on GitHub.
I think it would be pretty good to make use of the nuget feature to generate nuspec files and pack them based off a csproj. Atm I have to roll-my-own nuspec file for every output that I want. This stops me using a common workflow where I can call nuget spec in the same folder as the csproj to create my nuspec (with all the tags to use description and id from the project) and then calling nuget pack to create my nuget file. It saves me having to track every output I need.
Since it follows a convention that the nuspec will sit next to the csproj, could we have a feature to check for a nuspec sitting next to the csproj and then have OneBuild call pack on the csproj rather than the nuspec file?