search

lhotse-speech / lhotse

Tools for handling speech data in machine learning projects.
https://lhotse.readthedocs.io/en/latest/
Apache License 2.0
908 stars 205 forks source link

RFC - Python 3.7 end of life and Python 3.8 new syntax features #1217

Closed pzelasko closed 6 months ago

pzelasko commented 8 months ago

I'm considering stopping supporting Python 3.7 in the next Lhotse release (or one after), since Python 3.7 has reached end of life recently. That'd mean Lhotse library code could start using new syntax features from Python 3.8. This issue is an RFC to check with the community if this is problematic and to what extent. Please share your feedback.

CC @danpovey @csukuangfj @desh2608

desh2608 commented 8 months ago

Cool! We can start using the walrus operator now :)

csukuangfj commented 8 months ago

+1

PyTorch has already dropped support for Python 3.7 since torch 2.0.0.

We can use new features as described in https://docs.python.org/3/whatsnew/3.8.html if we target at only Python >=3.8.

pzelasko commented 6 months ago

It's merged. Feel free to use the "walrus", etc. going forward :)