lhr-solar / BPS

Battery Protection System Code
MIT License
4 stars 2 forks source link

moved delay_u and m to BSP_PLL, also renamed with BSP prefix #566

Closed ray4477 closed 1 year ago

ray4477 commented 1 year ago

Quality Assurance Checklist

To make reviews more efficient, please make sure the software feature meets the following standards and check everything off that meets the quality check. Once everything has been checked, the assigned reviewers will begin the review process. Edit this description to check off the list.

There are exceptions with all guidelines. As long as your decisions are justified, then you are good! Contact the reviewers or the leads about any exceptions.

Requirements

Things to Consider

manthanand commented 1 year ago

Make sure to change all calls to these functions in the test files as well.

manthanand commented 1 year ago

please fill out qac and request more reviewers than just me.