lhr-solar / BPS

Battery Protection System Code
MIT License
4 stars 2 forks source link

Change elements in Volt/Temp Arrays simulator #568

Open manthanand opened 1 year ago

manthanand commented 1 year ago

We shouldn't have to go through all the simulator data files and change the lengths of the voltage/temperature arrays every time we change config.h. We should have some functionality in simulator.c to change the length if it does not match, or have a script change all the lengths while still keeping the original fault.

ray4477 commented 1 year ago

this has already been done by Champers i think in the Simulator.c

manthanand commented 1 year ago

This hasn't. There is a TODO in Simulator.c which explains the issue.