Makefile print better

[connorl309]

Quality Assurance Checklist

To make reviews more efficient, please make sure the software feature meets the following standards and check everything off that meets the quality check. Once everything has been checked, the assigned reviewers will begin the review process. Edit this description to check off the list.

There are exceptions with all guidelines. As long as your decisions are justified, then you are good! Contact the reviewers or the leads about any exceptions.

Requirements

• [x] Followed Coding Style Guide
• [x] Code Build checks pass
• [x] No merge conflicts
• [x] Software feature has test associated with it.
• [x] Software feature has documentation for it updated.
• [x] If applicable, does software feature have simulation test associated with it (.json & out.json file)
• [x] Test provides useful information and uses relevant data to accurately represent BPS
  • NOTE: If test file already exists, use that one
• [x] 2 Members of the team have already reviewed my PR
  • NOTE: Approver will not look at PR if 2 other members haven't reviewed first
• [x] Did you Have Fun?

Things to Consider

• [ ] Even if the above are checked, is this the best way of writing my code?
  • It's possible to write code that works, but are there ways to make code more efficient?

[manthanand]

can you post a ss of the output when you make?

[connorl309]

can you post a ss of the output when you make?

Defines are specified as "DEFINES==VALUE/=VALUE...." Forward slash is the separator because Make functions cannot split on commas

[manthanand]

I don't think this looks pretty. Also, there shouldn't be errors in the code?

[manthanand]

Ig I wasn't too clear in the issue ticket. Could you make it so it prints out the values of all the #defines in the config file every time something is made?

[connorl309]

There is no possible way in GCC to evaluate our ternary macros, so they will be printed as such. Works with custom defines and still shows errors if you have invalid value combos such that compilation for other files dependent on the macros fails.

[manthanand]

tis a shame. ok

[manthanand]

I googled something, could you try this? XSTR((int)NUM_MINIONS) for all the defines?

[connorl309]

I googled something, could you try this? XSTR((int)NUM_MINIONS) for all the defines?

It just prefixes all the prints with "(int)"

e: ternaries are only evaluated at runtime apparently so I don't think we can precalculate the values unless we do a bunch more wacky stuff with the preprocessor

[manthanand]

Its mad stoopid if the ternaries are evaluated in runtime and not compile time.

[connorl309]

New changes pushed. should be finalized

[connorl309]

Ok so tests fail because some fixes from Champer's sim workflow branch aren't in here yet so some compilation explodes bc of array indices