lhr-solar / BPS

Battery Protection System Code
MIT License
4 stars 2 forks source link

Interrupt Priorities File #577

Closed MichaelMohn closed 1 year ago

MichaelMohn commented 1 year ago

Quality Assurance Checklist

To make reviews more efficient, please make sure the software feature meets the following standards and check everything off that meets the quality check. Once everything has been checked, the assigned reviewers will begin the review process. Edit this description to check off the list.

There are exceptions with all guidelines. As long as your decisions are justified, then you are good! Contact the reviewers or the leads about any exceptions.

Requirements

Things to Consider

MichaelMohn commented 1 year ago

Added the file "Interrupt Priorities" which defines the preempt and sub priority for the UART, CAN, and SPI interrupts.

pramukap commented 1 year ago

Should this commit include ADC? image

manthanand commented 1 year ago

Should this commit include ADC? image

It should include ADC, but shouldn't include things that already have defines for them. There is nothing in ADC that doesn't have defines for it already.

manthanand commented 1 year ago

This is awesome, thanks