lhr-solar / Electronics

Contains all Schematics/PCB files for each electrical system.
0 stars 2 forks source link

Discussion: Should we separate the various boards that we are making? #38

Closed chaseblock closed 4 years ago

chaseblock commented 4 years ago

We make quite a few PCBs for various purposes, and keeping them all in one repository kind of clutters everything. What do people think about starting to separate the various boards into their own repos? I've been coming back to this every once and a while, but I don't really know what I think about it right now.

A few things to consider to start us off:

Pros

Cons

I'm interested to hear what others think on this.

chaseblock commented 4 years ago

@HannahSLee14 @SijWoo @ClarkPoon @JimothyGreene @dimembermatt

chaseblock commented 4 years ago

Additional pro: We can integrate GitHub's teams feature to place each repository under the clear ownership of it's proper team, which might eliminate some confusion regarding who is responsible for creating which boards.

SijWoo commented 4 years ago

I like the idea of separating all the subsystem boards. If we had a main Electronics repo and in that repo we have submodules that links to the subsystems' hardware repos, would the second con be solved? Issues that are general or does not have an obvious home can go to that umbrella repo. Were you planning to separate each individual board to their own repos (e.g. BPS leader board and BPS minion board in their own repos) or each subsystem has their own hardware repo with all their boards in there?

I am down to have any type of reorganization of this repo, when I made this repo, I sort of did not expect all the systems to use git because the previous subsystem leads at the time were all independent and would not use git... This repo was not that well planned out on my part so the organization of all the boards was flawed since the beginning

chaseblock commented 4 years ago

I realize that I have not been updating the discussion here.

I think that for the most part we have agreement that we should separate this repo's components into several individual repositories (someone please correct me if I'm wrong; this is based on the conversations that I've had recently).

As far as the organization of the boards goes, I would personally be in favor of separating each KiCAD project into its own repository. I think this would make things like reverting to older revisions of a board easier, since it would no longer revert all changes to every board in that system as well. If anyone feels like the other option would be better, please speak up.

When we want to make the change, I suggest scheduling a time for it to take place so that all members can have any changes that they are working on checked in at that point. We can then separate the projects into several repositories. Hopefully if all goes well, any active development can rebase off of the modified master branch of its proper repository.

How does that plan sound?