BSP ADC - Githubissues

lhr-solar / Embedded-Sharepoint

This repository contains files that can be shared among us, the embedded design teams.

MIT License

3 stars 3 forks source link

Open aaravm4 opened 1 month ago

aaravm4 commented 1 month ago

Above is my proposed implementation of ADC Recieve in the BSP. Design decisions were made with the STMF24 in mind.

The PR has an empty BSP_ADC.h file for the actual implementation.

IshDeshpa commented 4 weeks ago

Can you write the header before workday so that I can review it?

IshDeshpa commented 4 weeks ago

Oh also it's not STMF24. We use two different processors on the PCBs:

STM32F413RHT
STM32L431CBT but then there's different ones on our Nucleo development boards as well that you'll probably use for testing. Your code will generically support most STM32s through the interface of the HAL.

Lakshay983 commented 4 weeks ago

can you check to see if the queue is full (for adding) or empty (for popping) before you do any queue accesses.

IshDeshpa commented 3 weeks ago

put it in Embedded-Sharepoint/bsp/Inc/BSP_ADC.h. The .c file will go in Embedded-Sharepoint/bsp/Src/BSP_ADC.c