search

lhr-solar / Embedded-Sharepoint

This repository contains files that can be shared among us, the embedded design teams.
MIT License
3 stars 3 forks source link

BSP UART Draft #72

Open fangjim opened 1 month ago

fangjim commented 1 month ago

image

Key considerations: Data in UART should be tied with a Bus since UART doesn't use 'id's like other peripherals do. Would also need to include error handling, e.g. dropped frames for UART RX

IshDeshpa commented 4 weeks ago

17

IshDeshpa commented 4 weeks ago

Make sure you know that the RX queue exists in the user code so that the user can allocate according to their needs and size of buffer. The RX queue will not be in the BSP layer itself (I know you may not have meant that by your diagram, just want to reiterate). I'd also make sure you know the specific UART interrupt handlers you will need to use. Otherwise block diagram looks good.

Lakshay983 commented 4 weeks ago

can you check to see if the queue is full (for adding) or empty (for popping) before you do any queue accesses.