liabru / jquery-match-height

a responsive equal heights plugin
MIT License
3.07k stars 799 forks source link

Maintain Scroll Position (Fails on Mobile) #121

Open zgjonbalaj opened 8 years ago

zgjonbalaj commented 8 years ago

I am having an issue with the maintain height on mobile phone, the page will jump to the top when you scroll all the way down. The flag is there but it doesnt seem to do any good, ive tried a few different things including a timeout, data-mh attributes.

This is my markup

`

liabru commented 8 years ago

Can you tell me the model of the phone and the browser version?

zgjonbalaj commented 8 years ago

It seems to be on all phones we've tested including

  1. Android Nexus 6 - Running Android 6.0.1
  2. iPhone 5 & 6

On Wed, Jul 6, 2016 at 12:21 PM, Liam notifications@github.com wrote:

Can you tell me the model of the phone and the browser version?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/liabru/jquery-match-height/issues/121#issuecomment-230825372, or mute the thread https://github.com/notifications/unsubscribe/AF4vuhxiaC-mN9rPWJIDTHy5Mdf-ijm6ks5qS9YLgaJpZM4JGMqy .

danjaywing commented 7 years ago

Did this ever get resolved? I'm noticing this on ios, page jumps caused by the _update method, _maintainScroll is set to true

zgjonbalaj commented 7 years ago

Nope, still experience this quite often my only fix is to add a set time out delay to the function. Moving it around to page load instead of document ready also seems to help.

On Oct 16, 2017 5:36 AM, "danjaywing" notifications@github.com wrote:

Did this ever get resolved? I'm noticing this on ios, page jumps caused by the _update method, _maintainScroll is set to true

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/liabru/jquery-match-height/issues/121#issuecomment-336833637, or mute the thread https://github.com/notifications/unsubscribe-auth/AF4vupPGBgjznN554j1-SZwvqXhYMNLqks5ssyOUgaJpZM4JGMqy .

liabru commented 7 years ago

Unfortunately _maintainScroll is only approximate, certain content changes will throw the estimation off more than others.

If it helps anyone, the exact implementation is just this line.

Maybe there's a bug with newer mobile browsers, does anybody have a good example link showing it?