liabru / matter-js

a 2D rigid body physics engine for the web ▲● ■
MIT License
16.7k stars 1.96k forks source link

Prevent object passing through walls / tunneling (implement CCD) #5

Open liabru opened 10 years ago

liabru commented 10 years ago

If you need fast moving or thin bodies a simple and robust solution is to sub-step using multiple updates per frame:

See the example here: https://github.com/liabru/matter-js/issues/5#issuecomment-1050738814

As well as sub-steps also consider:


Currently there is no continuous collision detection (CCD), so fast moving objects pass through other objects.

A description of the problem: http://www.stencyl.com/help/view/continuous-collision-detection

Solution is to implement a CCD algorithm.

One I'm currently considering is speculative contacts, see here and here.

"we compute the closest distance d between the two objects; the idea is that we want to remove exactly the right amount of velocity from A such that it will be exactly in touching contact with B on the next frame"

I've already implemented the code that extends the AABB based on object velocity.

The next part is to find the closest distance between two objects and remove the required velocity.

abataille commented 10 years ago

I just added a poor man's solution to the tunneling problem. It detects if a body is outside the world bounds and then reverses the velocity and translates the body back. I tried via an event. Here is the code. Please have a look. Events.on(_engine, 'afterTick afterRender', function (event) { // avoid tunneling for (var i = 0; i < _world.bodies.length; i++) { var bodyA = _world.bodies[i]; if (bodyA.isStatic || bodyA.isSleeping) { continue; } var outside = false; var adjustX = 0; var adjustY = 0; var epsilon = 0.01; if (bodyA.bounds.min.y + epsilon >= _world.bounds.max.y) { // bottom adjustY = Math.abs(bodyA.bounds.max.y - _world.bounds.max.y); Body.translate(bodyA, { x: 0, y: -adjustY }); bodyA.velocity.y = -1.0; outside = true; } if (bodyA.bounds.max.x - epsilon<= _world.bounds.min.x) { // left bodyA.velocity.x = 1.0; adjustX = Math.abs(bodyA.bounds.min.x - _world.bounds.min.x); Body.translate(bodyA, { x: adjustX, y: 0 }); outside = true; } if (bodyA.bounds.max.y - epsilon <= _world.bounds.min.y) { // Top adjustY = Math.abs(bodyA.bounds.min.y - _world.bounds.min.y); Body.translate(bodyA, { x: 0, y: adjustY // since body.bounds.min.y is negative }); bodyA.velocity.y = 1.0; outside = true; } if (bodyA.bounds.min.x + epsilon > _world.bounds.max.x) { // right bodyA.velocity.x = -1.0;adjustX = Math.abs(bodyA.bounds.max.x - _world.bounds.max.x); Body.translate(bodyA, { x: -adjustX, y: 0 }); outside = true; } if (outside) { Bounds.update(bodyA.bounds, bodyA.vertices, bodyA.velocity); } } });

liabru commented 10 years ago

Thanks for sharing, but does this work?

I ask because body.velocity is technically read only - the engine uses position Verlet meaning velocity is implicit to changes in position (see here)!

So what you need to do instead is simply set the body position to be inside the world, the engine will handle the velocity change for you.

Either way, as you say this is indeed a poor mans solution, as it's only a solution to going outside of the world bounds.

BTW note the event name is not 'afterTick afterRender', those are two separate events (that happen to relate to the same point in the step). You only need to use one here (e.g. it's like jQuery's events), otherwise this will run twice per step.

What we really need implementing is speculative contacts. I'll get round to it at some point hopefully!

abataille commented 10 years ago

You are right. velocity change is not necessary. Just the translation does it. I know, it does not work for inside objects, but at least it leaves the bodies at the table.

shakiba commented 10 years ago

+1

Danetag commented 9 years ago

Still experiencing this issue, I guess it's still unsolved?

liabru commented 9 years ago

It's a pretty big feature to implement really, I've played around with some ideas for this but I've not yet got much working. It's a tricky one.

I'm considering implementing a simple version for now (ray casting) that should prevent some of the more obvious tunneling cases.

Danetag commented 9 years ago

Ok I totally understand, thank you so much for all your hard work :)

anjiro commented 9 years ago

Note that increasing engine.timing.timeScale can cause this issue as well.

isaac-jordan commented 8 years ago

Still having this issue using latest master as of e698b6b5be5d8e4d5ddfb6fa06436916f5ef4772. I have somewhat mitigated it by halving the engine.timing.timeScale value. Not sure of the repercussions of this, but works for my simple use case.

homerjam commented 8 years ago

+1

slaskis commented 8 years ago

@liabru for https://cubeslam.com I ported a few SAT implementations to javascript but finally fell for this brilliant SAT implementation and converted it to be a part of this library.

It's very similar to your implementation but will also project ahead based on the polygons relative velocity to see if it will intersect and then returns a minimum translation vector which may be applied to keep two polygons from colliding if desired.

I found it to be quite stable and fast even in the pace of cube slam. Unfortunately google code just shut down so the implementation code for it is not viewable online anymore. But you can download it and have a look at the narrowphase implementation in lib/sim/physics.js#L74.

liabru commented 8 years ago

@slaskis I remember playing with cubeslam, awesome project!

Thanks for the info. I actually played with using SAT for continuous collisions but I couldn't get it working at the time, so I'll take a look at your implementation for some pointers.

slaskis commented 8 years ago

@liabru thanks! I hope it can help you get this sweet library even better

dcrockwell commented 8 years ago

+1 Seeing lots of tunneling with bodies passing through svg generated bodies.

ser10us commented 8 years ago

Is there any workaround for this issue? The proposal from @abataille doesn't work for me.

liabru commented 8 years ago

Not yet, I have a work in progress implementation. Depending on your needs, you could try doing some ray casts between updates (e.g. between centroids of bodies moving over a certain speed), if there's an intersection then move the body back. This won't be perfect but might help for some cases.

slaskis commented 8 years ago

@liabru would you mind sharing your in progress implementation as a PR or branch? I'm curious what it looks like and maybe we can help out?

IceReaper commented 8 years ago

Will this also allow collision with simple lines? To be more specific imagine a force field, which limits you to not pass from both sides but has no thickness. Which comes to the second idea of force fields coliding only in one direction, so you might move into the forcefield, but not leave it again. Imagine it as a simple polygon which has only a one-sided face, you walk through it as you cannot see it. If you try to move back you see a wall there. Used that feature to build some nasty tricky puzzles in prey a while ago, where the back-side was a portal placed inside a door. Which results in a door bringing you from a to b, but the same door back brings you from b to c :D

liabru commented 8 years ago

@slaskis it is in a very unstable state, I was trying a different approach than using SAT. But it looks like it's not going to be viable, so I'm going to try implement it again in the same way you did. Looking at your code, the key part seems to be these lines right?

liabru commented 8 years ago

@IceReaper if the implementation was perfect, then yes you could do a super thin body and it should never let anything through. I'm not sure if a practical implementation will be that accurate though, but hopefully.

Either way, for the kind of game mechanics you are talking about, it is better for you to implement that logic directly as it's not really in the scope of a physics engine but rather a game engine. Though once plugins are implemented (#213) you could use them to integrate this.

slaskis commented 8 years ago

@liabru yep, that's the part that uses the velocity to find the possible intersection.

And then the following lines may be useful for knowing how much to "push" the object back to the right side of the polygon.

liabru commented 8 years ago

I've made some progress on this based on the technique @slaskis mentioned, so far it seems pretty viable. I'll commit it to a branch as soon as it is working well enough.

liabru commented 8 years ago

I've just pushed my implementation to the ccd branch. If anybody wants to try it then use the build on that branch.

To use continuous collisions then set the body.continuous property to one of these values:

Where the 'dynamic' setting enables continuous collisions only when required based on velocity. This provides better performance than 'always' at the cost of slightly softer collisions. In a collision if either or both bodies have continuous collisions enabled then the check will be made.

See the included Example.continuousCollisions in the demo.

Let me know how you get on if you try it!

slaskis commented 8 years ago

@liabru that looks great, much more readable than my mess. I'll see if I get a chance to try it out this week

dcrockwell commented 8 years ago

Can we get some performance metrics between the different modes?

liabru commented 8 years ago

I could look into it, but I can say already that even the 'always' mode is very performant. Though it changes the behaviour of a lot of the demos because the collisions are detected earlier, which causes some things to collapse (the 'dynamic' mode is fine though because it only applies to high speed collisions).

joshkpeterson commented 8 years ago

Unfortunately I'm still experiencing a similar issue. Is there any way to cap the velocity of a body to a hard limit? This might be a quick fix for me.

Edit: it just so happens the bodies that they're going through are on the boundary of the canvas, also. Debugging someone else's code right now, not sure if there is another issue at play but figure the velocity cap would be worth trying.

liabru commented 8 years ago

Yeah you could cap the body velocity in the engine update event quite easily. Either way, the CCD code will get merged soon after I finish work on #213 so you won't need to after that.

joshkpeterson commented 8 years ago

I tried using the new build with the CCD code and setting continuous to 2 on all the bodies, but they're still going through walls / the boundary. The bodies are circles by the way, and the smaller they are the easier it is to get them to escape.

I also tried on engine update checking to see if the velocity is greater than (+/-)20, and if so, capping to (+/-)20, but it's still easy to get them out. Basically if you just click and drag them to the boundary and hold them there, they start spinning and bouncing like crazy and fly out.

There's probably another issue with my build that is causing this issue, but just wanted to let you know. I'd like to get you a case, but right now this is part of a larger framer.js project that I can't share. If I have time to break it out I will.

liabru commented 8 years ago

I tried using the new build with the CCD code and setting continuous to 2 on all the bodies, but they're still going through walls / the boundary.

What are you doing to cause them to escape? Setting velocity, adding force or using the mouse or constraints? Does the CCD demo work for you? How are the walls constructed?

Basically if you just click and drag them to the boundary and hold them there, they start spinning and bouncing like crazy and fly out.

There are some cases where CCD checks won't always be applied (e.g. things that 'teleport' or force positions, like constraints). Note that also there are no boundary checks, the space is infinite. If this is the case then it may be tricky to fix.

joshkpeterson commented 8 years ago

The walls are Matter.Bodies.rectangle(). I'm using a MouseConstraint to move the circles.

Edit: I just built the CCD demo, and I'm able to just drag the squares through the center rectangle at will not through the outer rectangles. I figured out this is because the squares are both 1) really big and 2) overlapping at the corners. I implemented in my own application, and using the new CCD stuff seems to help (circle's don't exit as often) but it doesn't take it all the way. The walls still have to be really big and overlapping.

So from where I stand the CCD fix isn't really working yet. If someone else want to build the demos and try out the CCD one that would be great.

Thanks again for your help.

BastianGanze commented 8 years ago

I build the demos and I am also able to drag the little rectangles through the small bar in the middle. I also managed to get them through by making them really, really fast/applying a lot of force.

I am using this branch for my game at the moment, and regardless of it not working at very, very, very high speeds it is making things much more stable, so this implementation is already a win for me. :)

This is how the demo looks at the start for me. This is how much I can "drag" it until it gets through.

staff0rd commented 7 years ago

Either way, the CCD code will get merged soon after I finish work on #213 so you won't need to after that.

Is it time? :)

wmike1987 commented 7 years ago

Any update on the ccd merge? I see it has a release-candidate label, that sounds promising!

Buri commented 7 years ago

Any updates on this issue?

liabru commented 7 years ago

Unfortunately there were some issues with this initial approach after a bunch of testing. I've got a new approach I'm working on though which should be simpler and more performant too.

maltenuhn commented 7 years ago

@liabru can the new approach do with help? Any specific things that'd push it along?

theodorklauritzen commented 7 years ago

I have an idea. The object falls through the wall because the hitbox is too small. If the hitbox was bigger it would fix it. The size should be the size to the object + the velocity in that direction. If the object fall down the hitbox should be the size of the object + the y-velocity downwards.

spiderworm commented 6 years ago

@liabru Any update on this? It looks like you abandoned the CCD branch and maybe are implementing your new approach in a different branch? Perhaps I can help code it up. I'm trying to make a game for mobile and this is the most performant 2D physics JS library I've found so far. Just need to get this bit fixed.

zxb5102 commented 6 years ago

Does that solve the problem now?

zxb5102 commented 6 years ago

I have a similar problem with my project

liabru commented 6 years ago

I have a partially working solution in a branch I've not yet pushed, but it still has some major issues. It's a tricky one. Maybe I should push it if other people are interested in helping?

spiderworm commented 6 years ago

@liabru Sounds like that might be a good idea? Along with a brief description of your approach, and of the problems that still need solving might be helpful.

billylo1 commented 6 years ago

In my use case, I managed to work around it by listening to collisionEnd event, check if the bodies were forced out of the viewport. If so, re-position that body to bring it back. (this is good enough for my use case because I only need to make sure no objects can get thrown out of the bounding rectangles.

Hope this helps.

qwertyquerty commented 6 years ago

Is this ever going to be continued?

pixelscripter commented 6 years ago

I was also wondering about that @qwertyquerty. Any progress on implementing CCD @liabru ?

soulofmischief commented 6 years ago

Also interested in seeing this feature.

whaqzhzd commented 6 years ago

Any progress on implementing CCD

cheneyweb commented 6 years ago

object passing through walls,I met this problem, too. I'm really looking forward to the problem being solved

7ammer commented 6 years ago

^^^ Me too