search

liady / webpack-node-externals

Easily exclude node modules in Webpack
MIT License
1.3k stars 62 forks source link

Do we need to set `externalsPresets` when `target: 'node'`? #116

Open OliverJAsh opened 2 years ago

OliverJAsh commented 2 years ago

Regarding this part of the docs:

https://github.com/liady/webpack-node-externals/blob/fc082618f98c564c92f3467523618dfcf4de2084/README.md#L32-L44

When target: 'node' I suspect the default for externalsPresets will be { node: true }:

https://github.com/webpack/webpack/blob/88978167ea2ee438761179dbbe2e21233dc9d34d/lib/config/defaults.js#L905

Therefore I'm not sure we need to set externalsPresets when target: 'node'?