liady / webpack-node-externals

Easily exclude node modules in Webpack
MIT License
1.3k stars 62 forks source link

importType option misses some type definitions. #128

Open mrdulin opened 1 year ago

mrdulin commented 1 year ago

Try to pass 'module' to importType option

externals: [nodeExternals({ importType: 'module' })],

Got error:

Type '"module"' is not assignable to type '"var" | "this" | "commonjs" | "amd" | "umd" | ImportTypeCallback | undefined'.ts(2322)

Below is the TS type definition of importType option

/**
 * The method in which unbundled modules will be required in the code. Best to leave as
 * 'commonjs' for node modules.
 * @default 'commonjs'
 */
importType?: 'var' | 'this' | 'commonjs' | 'amd' | 'umd' | ImportTypeCallback | undefined;

Expected:

All external types should be supported.

The above configuration works at runtime.

Version information:

"webpack": "^5.80.0",
"@types/webpack": "^5.28.1",
"webpack-node-externals": "^3.0.0"
tobiaszpiwowarczyk commented 1 year ago

Hello @mrdulin

The issue has been fixed in version ^3.0.1. Try do update @types/webpack-node-externals to the latest version and see if it works.

mrdulin commented 12 months ago

@tobiaszpiwowarczyk Thanks.